ticdc: document ignore-update-only-columns filter - #23523
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe documentation adds the Kafka-only ChangesTiCDC filter documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The PR documents the new filter but omits the exception for updates involving primary or unique key columns, which could mislead users about when events are filtered. The change is mergeable with explicit owner follow-up to align the API description with the documented behavior. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 538b94ba-d150-4158-8ce6-c3717b20b445
📒 Files selected for processing (3)
ticdc/ticdc-changefeed-config.mdticdc/ticdc-filter.mdticdc/ticdc-open-api-v2.md
| | `ignore_sql` | `STRING ARRAY` type. For example, `["^drop", "add column"]` means to filter out DDL statements that start with `DROP` or contain `ADD COLUMN`. (Optional) | | ||
| | `ignore_update_new_value_expr` | `STRING ARRAY` type. For example, `"gender = 'male'"` means to filter out the UPDATE DML statements with the new value `gender = 'male'`. (Optional) | | ||
| | `ignore_update_old_value_expr` | `STRING ARRAY` type. For example, `"age < 18"` means to filter out the UPDATE DML statements with the old value `age < 18`. (Optional) | | ||
| | `ignore_update_only_columns` | `STRING ARRAY` type. Introduced in v8.5.8 and applicable only to Kafka downstreams. If all columns whose values are changed in an UPDATE event are included in this array, TiCDC filters out the event. For example, `["version", "updated_at"]`. (Optional) | |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Document the primary/unique-key exception.
Line 298 states that every matching update is filtered. This conflicts with ticdc/ticdc-filter.md: TiCDC does not filter the event when a changed column is a primary key or unique key column.
As per path instructions: “For every actionable issue, provide a GitHub committable suggestion block when the fix can be safely applied to contiguous lines.”
Apply this suggestion
| | `ignore_update_only_columns` | `STRING ARRAY` type. Introduced in v8.5.8 and applicable only to Kafka downstreams. If all columns whose values are changed in an UPDATE event are included in this array, TiCDC filters out the event. For example, `["version", "updated_at"]`. (Optional) | | |
| | `ignore_update_only_columns` | `STRING ARRAY` type. Introduced in v8.5.8 and applicable only to Kafka downstreams. If all columns whose values are changed in an `UPDATE` event are included in this array, TiCDC filters out the event, except when the event changes a primary key or unique key column. For example, `["version", "updated_at"]`. (Optional) | |
Source: Path instructions
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
Summary by CodeRabbit
New Features
ignore-update-only-columnsevent-filter option for Kafka changefeeds.Documentation